# HG changeset patch
# User Javier Armendáriz <javier.armendariz@openbravo.com>
# Date 1515412410 -3600
#      Mon Jan 08 12:53:30 2018 +0100
# Node ID 216e2ca3cf178e5a743df97f84754254ecb7e6a9
# Parent  858d3384985d28af7a534947a2086ec67d2be7ef
Fixed bug 35268: No message displayed on request timeout responses.

This patch fixes an issue where RPC calls didn't handle timeout responses properly because its sent as an Object instead of a String. Now this response is sanitized before Smarclient evaluates the received result.

diff --git a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
--- a/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
+++ b/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
@@ -798,7 +798,11 @@
     if (response.status !== isc.RPCResponse.STATUS_SUCCESS && isc.isA.Function(request.errorCallback)) {
       request.errorCallback(request, response);
     }
-    return this._originalEvalResult(request, response, results);
+
+    return this._originalEvalResult(request, response, this.sanitizeResults(results));
+  },
+  sanitizeResults: function (results) {
+    return isc.isA.Object(results) ? JSON.stringify(results) : results;
   },
 
   // Escape characters that are not properly handled in JavaScript's eval. See issue #36788.