Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0010617Openbravo ERP03. Procurement managementpublic2009-09-14 19:252009-10-13 08:12
Reportershuehner 
Assigned Toshuehner 
PriorityhighSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.40 
Target VersionFixed in Version2.40MP10 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0010617: CreateFromMultiple_Receipt_data.xsql has optional filter on M_LOCATOR.M_LOCATOR_TYPE_ID which was removed in 2.3x -> 2.40
DescriptionThis xsql-file:

src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql

has the following optional parameter:

<Parameter name="mLocatortypeId" optional="true" after="AND 1=1" text=" AND L.M_LOCATOR_TYPE_ID = ? "/>

referencing a now non-existant column m_locator_type_id in the m_locator table. This column was removed somewhere between 2.3x -> 2.40

Planned changes to speed up the build would execute the slqc-queries and also include this optional parameter in the query which will obviously fail.

The query (and parameter) is used from the CreateFromMultiple servlet.
Steps To Reproduce
Proposed SolutionRemove the optional parameter from the xsql file (as the column does not exist) and check/remove/change the locator_type logic in the servlet.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0010588 closed shuehner CreateFromMultiple_Receipt_data.xsql has optional filter on M_LOCATOR.M_LOCATOR_TYPE_ID which was removed in 2.3x -> 2.40 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2009-09-15 20:57shuehnerTypedefect => backport
2009-09-15 20:57shuehnerfix_in_branch => 2.40
2009-09-15 21:28hgbotCheckin
2009-09-15 21:28hgbotNote Added: 0020101
2009-09-15 21:28hgbotStatusscheduled => resolved
2009-09-15 21:28hgbotResolutionopen => fixed
2009-09-15 21:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.40/rev/5a1857b90f63a187dfd18340df2e47fdea1d3539 [^]
2009-09-29 12:02hgbotCheckin
2009-09-29 12:02hgbotNote Added: 0020438
2009-09-29 12:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/stable/2.40/rev/5a1857b90f63a187dfd18340df2e47fdea1d3539 [^] => http://code.openbravo.com/erp/stable/2.40_pageddatagrid/rev/5a1857b90f63a187dfd18340df2e47fdea1d3539 [^]
2009-10-13 08:12arunkumarStatusresolved => closed
2009-10-13 08:12arunkumarNote Added: 0020951
2009-10-13 08:12arunkumarFixed in Version => 2.40MP10

Notes
(0020101)
hgbot   
2009-09-15 21:28   
Repository: erp/stable/2.40
Changeset: 5a1857b90f63a187dfd18340df2e47fdea1d3539
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Sep 15 21:28:26 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40/rev/5a1857b90f63a187dfd18340df2e47fdea1d3539 [^]

Fixed 10617: Fix sql error by removing filter on now non-existant column
- The file did filter on m_locator.m_locator_type_id which was removed before 2.40
- Removes code the combobox for 'Locator Type' from the html,xml,java
- Remove use and pass down to parameter of the m_locator_type_id value

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
---
(0020438)
hgbot   
2009-09-29 12:02   
Repository: erp/stable/2.40_pageddatagrid
Changeset: 5a1857b90f63a187dfd18340df2e47fdea1d3539
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Sep 15 21:28:26 2009 +0200
URL: http://code.openbravo.com/erp/stable/2.40_pageddatagrid/rev/5a1857b90f63a187dfd18340df2e47fdea1d3539 [^]

Fixed 10617: Fix sql error by removing filter on now non-existant column
- The file did filter on m_locator.m_locator_type_id which was removed before 2.40
- Removes code the combobox for 'Locator Type' from the html,xml,java
- Remove use and pass down to parameter of the m_locator_type_id value

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.html
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt.xml
M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql
---
(0020951)
arunkumar   
2009-10-13 08:12   
Tested & Working fine.