Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0029035Openbravo ERPA. Platformpublic2015-02-23 18:262015-05-20 12:37
Reportermaite 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket34318
Regression levelProduction - Confirmed Stable
Regression date2014-11-13
Regression introduced in release3.0PR15Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c0aa8da15e9c [^]
Triggers an Emergency PackNo
Summary0029035: Process definition containing parameters defined as "window", should automatically inherit permissions
DescriptionProcess definition containing parameters defined as "window", should automatically inherit permissions
Steps To Reproduce1. Access application and change to use a manual role, as "España Finance"
2. Access Sales Invoice "1000133" and run "Add payment" process
3. Realize that no data is shown in "Order/Invoice" grid. Problem is that this role has not access to windows contained in that process definition.

Following error can be found in openbravo.log:

2015-02-23 18:16:27,072 [ajp-localhost%2F127.0.0.1-8809-10] ERROR org.openbravo.client.kernel.KernelUtils - AccessTableNoView
org.openbravo.client.kernel.OBUserException: AccessTableNoView
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:742)
    
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00297593.0PR15Q2 closed inigosanchez Process definition containing parameters defined as "window", should automatically inherit permissions 
depends on backport 00297603.0PR15Q1.4 closed inigosanchez Process definition containing parameters defined as "window", should automatically inherit permissions 
related to defect 00289993.0PR15Q3 closed inigosanchez Grant access to buttons is not working fine depending on the process you want to configure 
related to defect 00290663.0PR15Q2 closed inigosanchez Is not possible to add new payment from transaction window when working with a role defined as "Manual" 
related to defect 00306193.0PR16Q1 closed Triage Omni OMS Error "java.text.ParseException: Unparseable date: "null" received when running Add Payment process from a copied window 
related to defect 00313863.0PR16Q1 closed aferraz Error shown in Add Payment when role has no access to Financial Account window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-02-23 18:26maiteNew Issue
2015-02-23 18:26maiteAssigned To => AugustoMauch
2015-02-23 18:26maiteOBNetwork customer => Yes
2015-02-23 18:26maiteModules => Core
2015-02-23 18:26maiteSupport ticket => 34318
2015-02-23 18:26maiteResolution time => 1430690400
2015-02-23 18:26maiteTriggers an Emergency Pack => No
2015-02-23 18:26maiteIssue Monitored: networkb
2015-02-23 18:27maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7743#r7743
2015-02-23 18:32alostaleRelationship addedrelated to 0028999
2015-02-23 18:33alostaleStatusnew => acknowledged
2015-02-23 18:54ngarciaIssue Monitored: ngarcia
2015-02-25 17:39maiteRelationship addedrelated to 0029066
2015-02-26 08:24alostaleRelationship addedrelated to 0029049
2015-02-26 08:24alostaleRelationship deletedrelated to 0029049
2015-03-09 17:36jonalegriaesarteResolution time1430690400 =>
2015-03-11 08:09alostalePriorityhigh => urgent
2015-03-11 08:09alostaleTarget Version3.0PR15Q2 =>
2015-03-17 14:37alostaleAssigned ToAugustoMauch => platform
2015-03-23 21:57inigosanchezAssigned Toplatform => inigosanchez
2015-03-24 09:21inigosanchezStatusacknowledged => scheduled
2015-05-04 12:14alostaleRegression level => Production - Confirmed Stable
2015-05-04 12:14alostaleRegression date => 2014-11-13
2015-05-04 12:14alostaleRegression introduced in release => 3.0PR15Q1
2015-05-04 12:14alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c0aa8da15e9c [^]
2015-05-04 12:14alostalePriorityurgent => immediate
2015-05-04 12:14alostaleNote Added: 0076932
2015-05-04 12:14alostaleStatusscheduled => feedback
2015-05-04 12:14alostaleStatusfeedback => new
2015-05-04 12:15alostaleStatusnew => scheduled
2015-05-04 14:41inigosanchezReview Assigned To => alostale
2015-05-04 14:42hgbotCheckin
2015-05-04 14:42hgbotNote Added: 0076945
2015-05-04 14:42hgbotStatusscheduled => resolved
2015-05-04 14:42hgbotResolutionopen => fixed
2015-05-04 14:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2aca706e9b8c4ca7093805dd2614418ce030f5b0 [^]
2015-05-04 14:50inigosanchezIssue Monitored: alostale
2015-05-05 08:06alostaleNote Added: 0076978
2015-05-05 08:06alostaleStatusresolved => closed
2015-05-05 08:06alostaleFixed in Version => 3.0PR15Q3
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077199
2015-05-20 12:37eugeniIssue Monitored: eugeni
2015-08-21 10:08maiteRelationship addedrelated to 0030619
2015-11-06 10:33aferrazRelationship addedrelated to 0031386

Notes
(0076932)
alostale   
2015-05-04 12:14   
Workaround: grant explicit access to P&E windows
(0076945)
hgbot   
2015-05-04 14:42   
Repository: erp/devel/pi
Changeset: 2aca706e9b8c4ca7093805dd2614418ce030f5b0
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon May 04 13:54:07 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2aca706e9b8c4ca7093805dd2614418ce030f5b0 [^]

Fixed bug 29035:Problems with inherited permissions in process definition

The problem was that when a process containing parameters defined as "window" is
launched , this manual role has not access to windows contained in that process
definition.

The cause of this issue is that before 14Q3, no security check was done on P&E
grids, so data always was retrieved.From 15Q1, security is checked requiring
explicit access to P&E grid.

The issue is fixed by inheriting access from the process, this is if the process
is accessible the grid within the P&E doesn't require to have explicit access
but inherits from the process itself.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0076978)
alostale   
2015-05-05 08:06   
code reviewed

tested in:
* Process defined as a button in a standard window
* Process accessed from menu
(0077199)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test