0031479: NPE in CloneOrderActionHandler as result of logic error in code

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031479

Openbravo ERP

07. Sales management

public

2015-11-14 13:21

2015-11-23 21:17

Reporter

shuehner

Assigned To

shuehner

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

vmromanos

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031479: NPE in CloneOrderActionHandler as result of logic error in code

Description

This class has a logic error in its code leading to NPE always in case of bdPriceList being null

Stopped by eclipse warning: NullPointerAccess

- if (!"".equals(bdPriceList) || bdPriceList != null
+ if (!"".equals(bdPriceList) && bdPriceList != null
|| !bdPriceList.equals(BigDecimal.ZERO.setScale(bdPriceList.scale()))) {

Problem is wrong use of || where apparently && was intended.
Result if when unfixed and bdPriceList is null that the null check does not work in practice and the following check for ZERO triggers an NPE

Steps To Reproduce

Check Eclipse warning about NullPointerAccess.

Probably also reproducible by finding functional testing flow ensuring bdPriceList being null when accessing that part of the code.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

caused by	defect	0020706	3.0MP14	closed	jecharri	To clone sales order is missing the list price value
blocks	feature request	0031477		new	shuehner	Tracking issue to reduce the huge number of eclipse warnings in pi