Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031557Openbravo ERPA. Platformpublic2015-11-23 08:322015-12-21 10:10
Reporteralostale 
Assigned Toalostale 
PrioritylowSeveritytrivialReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toshuehner
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0031557: NumberFilter: unneeded @SuppressWarnings("unused") annontation
DescriptionIn org.openbravo.base.filter.NumberFilter.accept there is a @SuppressWarnings("unused") annotation which causes an unnecessary unneeded warning because the method is public and it is actually used.
Steps To ReproduceSee warning in enclipse
Proposed SolutionRemove annotation
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031477 new shuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
related to defect 00302823.0PR15Q3 closed shuehner Supress some warnings about 'unused object allocation' where this is intentional 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-23 08:32alostaleNew Issue
2015-11-23 08:32alostaleAssigned To => alostale
2015-11-23 08:32alostaleOBNetwork customer => No
2015-11-23 08:32alostaleModules => Core
2015-11-23 08:32alostaleTriggers an Emergency Pack => No
2015-11-23 08:33alostaleRelationship addedrelated to 0031477
2015-11-23 08:33alostaleRelationship addedrelated to 0030282
2015-11-23 08:36hgbotCheckin
2015-11-23 08:36hgbotNote Added: 0082055
2015-11-23 08:36hgbotStatusnew => resolved
2015-11-23 08:36hgbotResolutionopen => fixed
2015-11-23 08:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4b1da36d4b2cc391880073b4442440b1c89e3f75 [^]
2015-11-23 08:36alostaleReview Assigned To => shuehner
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082261
2015-12-21 10:10shuehnerNote Added: 0082882
2015-12-21 10:10shuehnerStatusresolved => closed

Notes
(0082055)
hgbot   
2015-11-23 08:36   
Repository: erp/devel/pi
Changeset: 4b1da36d4b2cc391880073b4442440b1c89e3f75
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Nov 23 08:35:22 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4b1da36d4b2cc391880073b4442440b1c89e3f75 [^]

fixed issue 31557: NumberFilter unneeded @SuppressWarnings("unused")

---
M src-core/src/org/openbravo/base/filter/NumberFilter.java
---
(0082261)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082882)
shuehner   
2015-12-21 10:10   
Reviewed.

Non-functional change only.

Change was to revert an earlier change by myself to suppress a optionally shown eclipse warning (Unused object allocation).

However as that warning is optional that earlier change triggered a new warning about that supression being unused when eclipse is used with the openbravo standard warning configuration.

So that revert here makes sense for now to not have a new warning by default.