Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033104Retail ModulesWeb POSpublic2016-06-01 14:342016-06-28 11:28
Reporterguillermogil 
Assigned Tomario_castello 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033104: Import Entry Post Processor does not get called if the entity goes to errors while importing
DescriptionIf you click "Save Again" button on Errors while importing and the Order/Cash Up/Cash Management gets imported properly it should call to that Entity Post Processor.
Right now there are several workflows implemented that are not getting sync due to this bug.
Steps To ReproduceOn a local environment with debugging enabled:
* Close the current period
* Login on WebPOS
* Add an Avalanche Transceiver
* Pay it totally
* Go to errors while importing window on the backend
Verify that the Order is there

* Go to Eclipse
* Put a Breakpoint on Import Entry Post Processor
* Go to the backend select the previously created error and click "Save Again" button

Verify that Import Entry Post Processor does not get call.
Proposed SolutionOn Save call to Import Entry Post Processor.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041109 new Triage Platform Base Openbravo ERP Improvements in ImportEntryPreProcessor/ImportEntryPostProcessor 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-01 14:34guillermogilNew Issue
2016-06-01 14:34guillermogilAssigned To => Retail
2016-06-01 14:34guillermogilOBNetwork customer => Yes
2016-06-01 14:34guillermogilResolution time => 1465941600
2016-06-01 14:34guillermogilTriggers an Emergency Pack => No
2016-06-01 15:44OrekariaStatusnew => acknowledged
2016-06-15 18:20mario_castelloAssigned ToRetail => mario_castello
2016-06-17 20:32hgbotCheckin
2016-06-17 20:32hgbotNote Added: 0087638
2016-06-17 20:32hgbotStatusacknowledged => resolved
2016-06-17 20:32hgbotResolutionopen => fixed
2016-06-17 20:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2 [^]
2016-06-19 11:31marvintmReview Assigned To => marvintm
2016-06-19 11:31marvintmStatusresolved => closed
2016-06-28 11:21hgbotCheckin
2016-06-28 11:21hgbotNote Added: 0088019
2016-06-28 11:28hgbotCheckin
2016-06-28 11:28hgbotNote Added: 0088020
2019-06-17 17:15caristuRelationship addedrelated to 0041109

Notes
(0087638)
hgbot   
2016-06-17 20:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Jun 16 08:52:09 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6b6a0d63155d0e41c4bcecabd6b49632c6c13ea2 [^]

Fixed issue 33104: Added ImportEntryPostProcessor in saveDataAction process to execute the entry post process

---
M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java
---
(0088019)
hgbot   
2016-06-28 11:21   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d81183367c8ff1474294ded8d8ae7aa4a0917c11
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 28 08:44:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d81183367c8ff1474294ded8d8ae7aa4a0917c11 [^]

Related to issue 33104. Two changes have been made:
- ImportEntry will not be committed before the record is processed. This means in turn that if the record fails with error, then it will be rolled back. If it is processed correctly, it will be finally committed directly in processed status.
- Hooks will not be executed if the process fails with error.

---
M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java
---
(0088020)
hgbot   
2016-06-28 11:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a13bead4c824861b783c49af93b64190b52bf791
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jun 28 11:28:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a13bead4c824861b783c49af93b64190b52bf791 [^]

Related to issue 33104. Two additional changes:
- Removed outdated comment.
- Now import entry will be marked as processed before the record is executed. This will avoid the problem of having a very short but real amount of time in which the record has been processed, and the import entry is committed with status Initial, which could theoretically trigger a second processing action of the import entry by the thread. This problem would have happened because the execution of the process already commits the transaction at the end, if everything works well.

---
M src/org/openbravo/retail/posterminal/SaveDataActionHandler.java
---