0034368: ant jar should fail if mercurial detects unknown java files

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0034368

Openbravo ERP

Y. DBSourceManager

public

2016-11-02 17:54

2022-02-01 08:09

Reporter

AugustoMauch

Assigned To

Triage Platform Base

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

acknowledged

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0034368: ant jar should fail if mercurial detects unknown java files

Description

This changeset [1] ensured that the ant jar task cannot be executed if there are local changes. This is done by checking that the revision id does not contain the '+' character.

The problem is that if there are new java files that have not been added to the repo, the check done in [1] does not detect it and the jar file will be created.

[1] https://issues.openbravo.com/view.php?id=32809 [^]

Steps To Reproduce

- Create a new Java file
- Check that mercurial detects it as unknown: hg st -u
- Check that mercurial does not detect the change in its revision id: hg id -i
- Check that the ant jar task can be executed.

Proposed Solution

Check if there are unknown java files before creating the jar:

hg st -u | grep java

Additional Information