Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034878Openbravo ERP03. Procurement managementpublic2017-01-09 21:452017-01-13 16:41
Reportermarkmm82 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tomarkmm82
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034878: Some changes needed to improve the performance in pending goods receipt window
DescriptionThere are some changes in the Pending Goods Receipt window can be improved:
1. There is an extra query to the database to calculate the record's count. It makes more slow the window loading.
2. It is used a deprecated API of XSQL's logic to work with the limits of query.
3. The message is showing must be reviewed to make more descriptive.
Steps To ReproduceAs system administrator
  Go to preference screen and change the Forms Limit preference value to 3

As International Group Admin role
  Create 4 Purchase Order and complete it
  Go to Pending Goods Receipt and a warning message is shown indicating that the form data it's limited to 3
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0034877 closed rqueralta Some changes needed to improve the performance in pending goods receipt window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-01-09 21:50markmm82Typedefect => backport
2017-01-09 21:50markmm82Target Version => 3.0PR17Q1
2017-01-13 16:39hgbotCheckin
2017-01-13 16:39hgbotNote Added: 0093557
2017-01-13 16:39hgbotStatusscheduled => resolved
2017-01-13 16:39hgbotResolutionopen => fixed
2017-01-13 16:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/f682debee7de13d606326aa65f4b228add76099f [^]
2017-01-13 16:41markmm82Review Assigned To => markmm82
2017-01-13 16:41markmm82Note Added: 0093559
2017-01-13 16:41markmm82Statusresolved => closed
2017-01-13 16:41markmm82Fixed in Version => 3.0PR17Q1

Notes
(0093557)
hgbot   
2017-01-13 16:39   
Repository: erp/backports/3.0PR17Q1
Changeset: f682debee7de13d606326aa65f4b228add76099f
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Jan 13 10:37:15 2017 -0500
URL: http://code.openbravo.com/erp/backports/3.0PR17Q1/rev/f682debee7de13d606326aa65f4b228add76099f [^]

Fixed issue 34878: Some changes needed to improve the performance in Pending GR

To improve the performance in Pending Goods Receipt window, the extra query was
remove and the message was corrected.

---
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending.java
M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPending_data.xsql
---
(0093559)
markmm82   
2017-01-13 16:41   
Code review + Testing OK