Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040680Openbravo ERP09. Financial managementpublic2019-04-25 11:272019-06-11 12:30
ReporterAtulOpenbravo 
Assigned ToTriage Omni OMS 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040680: Remove unsed methods in AdvPaymentMngtDao, TransactionsDao, MatchTransactionDao classes.
DescriptionBelow is the list of several methods in classes that are no used.
01. AdvPaymentMngtDao.getReconciliationDetailReport
02. AdvPaymentMngtDao.isPaymentMadeStatus
03. AdvPaymentMngtDao.createAPRMReadyPreference
04. AdvPaymentMngtDao.getCustomerPaymentsWithUsedCredit
05. AdvPaymentMngtDao.getReconciliationSummaryReport
06. MatchTransactionDao.getClearedLinesAmount
07. MatchTransactionDao.checkAllLinesCleared
08. MatchTransactionDao.getLastReconciliationUnmatchedBalance

Verification should be done whether they are not used in external modules.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0032688 acknowledged Triage Platform Base remove unused resources 
related to feature request 00357883.0PR19Q3 closed AtulOpenbravo Remove obsolete, disabled & non-working class: org.openbravo.advpaymentmngt.ad_forms.Transactions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-04-25 11:27AtulOpenbravoNew Issue
2019-04-25 11:27AtulOpenbravoAssigned To => Triage Finance
2019-04-25 11:27AtulOpenbravoOBNetwork customer => No
2019-04-25 11:27AtulOpenbravoModules => Core
2019-04-25 11:27AtulOpenbravoTriggers an Emergency Pack => No
2019-04-25 11:27AtulOpenbravoRelationship addedrelated to 0032688
2019-04-25 11:36AtulOpenbravoNote Added: 0111305
2019-06-11 11:14AtulOpenbravoRelationship addedrelated to 0035788
2019-06-11 11:22AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=18905#r18905
2019-06-11 12:30AtulOpenbravoNote Added: 0112578

Notes
(0111305)
AtulOpenbravo   
2019-04-25 11:36   
** AdvPaymentMngtDao.createAPRMReadyPreference used at below line in org.openbravo.erputil.aprmigrationtool module located at allMods-by-types-2019-04-05/allMods-USUP (External modules folder provided by Stefan)

org.openbravo.erputil.aprmigrationtool/src/org/openbravo/erputil/aprmigrationtool/entity/MigrationTool.java:99: new AdvPaymentMngtDao().createAPRMReadyPreference()
(0112578)
AtulOpenbravo   
2019-06-11 12:30   
- TransactionsDao.post
- TransactionsDao.getTransactionsToReconciled

Removed in related issue 35788 commit

https://code.openbravo.com/erp/devel/pi/rev/a1ba443733e78baf9395b0faaab4fa01d8ca6f9a [^]