Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0040833Openbravo ERP05. Production managementpublic2019-04-10 11:412019-06-05 15:54
Reportershuehner 
Assigned Tononofrancisco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.2Fixed in Version3.0PR19Q1.2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0040833: SequenceProductCreate.getLineNum is not using bind-parameters
DescriptionThis code is not using bind-params:

    String hql = " SELECT COALESCE(MAX(l.lineNo),0)+10 AS DefaultValue FROM ManufacturingOperationProduct l WHERE l.mASequence.id= '"
        + SequenceId + "'";
    Query<Long> q = OBDal.getInstance().getSession().createQuery(hql, Long.class);
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00405743.0PR19Q3 closed nonofrancisco SequenceProductCreate.getLineNum is not using bind-parameters 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-05-09 23:25nonofranciscoTypedefect => backport
2019-05-09 23:25nonofranciscoTarget Version => 3.0PR19Q1.2
2019-06-05 15:26hgbotCheckin
2019-06-05 15:26hgbotNote Added: 0112425
2019-06-05 15:26hgbotStatusscheduled => resolved
2019-06-05 15:26hgbotResolutionopen => fixed
2019-06-05 15:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af [^]
2019-06-05 15:54SandrahuguetReview Assigned To => Sandrahuguet
2019-06-05 15:54SandrahuguetNote Added: 0112427
2019-06-05 15:54SandrahuguetStatusresolved => closed
2019-06-05 15:54SandrahuguetFixed in Version => 3.0PR19Q1.2

Notes
(0112425)
hgbot   
2019-06-05 15:26   
Repository: erp/backports/3.0PR19Q1.2
Changeset: 43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Wed May 01 22:53:24 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/43a60afc9f2d5c2d83dce9c8b5c9f3ccae8094af [^]

Fixes issue 40833: Uses bind parameter.

Instead of string concatenation, bind parameter is used to build the query.

---
M src/org/openbravo/erpCommon/ad_actionButton/SequenceProductCreate.java
---
(0112427)
Sandrahuguet   
2019-06-05 15:54   
code review + testing ok