Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0045473Openbravo ERPA. Platformpublic2020-11-20 11:032022-02-01 07:24
Reportershuehner 
Assigned ToTriage Platform Base 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0045473: Add 2 more visible warnings for '>1 tabs on root-level of a window', check for '2 tabs has same seqno,tablevel'
DescriptionIn some projects/customization both of the following window definition mistakes happen sometimes:
a.) Define >1 tab on root-level of a window
b.) Have 2 tabs with same tablevel & seqno

The first one has a log.WARN in ViewComponent but that is hard to stop as only seen at runtime + hidden inside junit log output of CI junit ViewGeneration.

The second one does not have any specific check about it.

However both cause problems
a.) Random, wrong Tab ordering/parent child relation for the UI
b.) IndexesTest.testSubTabs crashing with 'more than one row returned by a subquery used as an expression'

That 2nd one is especially hard to debug to get to the wrong tab

Steps To ReproduceCreate the wrong window definition intentionally and check on UI behavior.
Attached screenshots for ad_tab information shows two concrete examples seen in some customer modules.
Proposed SolutionEither add a WADValidation or specific JUnit test searching for those two error and give a clear output what is wrong.
Probably WADValidation makes sense here as it exists as to check 'AD definition for tables/windows/tab' anyway.
Additional Information
TagsNo tags attached.
Relationships
depends on design defect 0045818 new Triage Finance Tracking issue: Modules adding tabs with same tablevel & seqno as an existing tab should be fixed 
Not all the children of this issue are yet resolved or closed.
Attached Filespng 45473-example-a.png (20,265) 2020-11-20 11:04
https://issues-new.openbravo.com/file_download.php?file_id=15101&type=bug
png

png 45473-example-b.png (109,728) 2020-11-20 11:04
https://issues-new.openbravo.com/file_download.php?file_id=15102&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2020-11-20 11:03shuehnerNew Issue
2020-11-20 11:03shuehnerAssigned To => platform
2020-11-20 11:03shuehnerOBNetwork customer => No
2020-11-20 11:03shuehnerModules => Core
2020-11-20 11:03shuehnerTriggers an Emergency Pack => No
2020-11-20 11:04shuehnerFile Added: 45473-example-a.png
2020-11-20 11:04shuehnerFile Added: 45473-example-b.png
2020-11-20 11:06shuehnerNote Added: 0124520
2020-11-20 11:14shuehnerNote Added: 0124526
2021-01-29 14:08shuehnerRelationship addeddepends on 0045818
2022-02-01 07:24alostaleAssigned Toplatform => Triage Platform Base

Notes
(0124520)
shuehner   
2020-11-20 11:06   
Note there is existing code to check in StandardWindowComponent.getRootTabComponent()

It checks
- Case a.) from above
- Does NOT check case b.)
- But checks an additional third case

That new check probably should cover/take-over all three of those.
(0124526)
shuehner   
2020-11-20 11:14   
Example warning from getRootTabComponent for case a.)

    [junit] 09:37:32.651 WARN org.openbravo.client.application.window.StandardWindowComponent - Window ABC Activity 134 has more than on tab on level 0, choosing an arbitrary root tab