Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004721Openbravo ERPA. Platformpublic2008-08-26 17:192022-02-01 08:08
Reportershuehner 
Assigned ToTriage Platform Base 
PrioritylowSeverityminorReproducibilityN/A
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0004721: Cleanup HTML-templates: remove the placeholder for paramLanguage
DescriptionCurrently each HTML-template has a line like:

<SCRIPT language="JavaScript" type="text/javascript" id="paramLanguage"> defaultLang = "en_US";</SCRIPT>

or before the spanish->english renaming:
<SCRIPT language="JavaScript" type="text/javascript" id="paramLanguage"> LNG__POR_DEFECTO = "en_US";</SCRIPT>

the content of this script-tag gets overwritten by the XML-engine with the value provided by the corresponding java-servlet. The the tags-content in the HTML-template seems to be unnecessary and could be removed.

The same is true for the following:
<SCRIPT language="JavaScript" type="text/javascript" id="paramDirectory">var baseDirection = "http://yourSite/web/";</SCRIPT> [^]
Steps To Reproduce
Proposed SolutionSimplify all templates to read only:

<script language="JavaScript" type="text/javascript" id="paramLanguage"></script>

and

<script language="JavaScript" type="text/javascript" id="paramDirectory">/script>
Additional Information
TagsReleaseCandidate
Relationships
related to feature request 0000421pi acknowledged dbaz Make interface components HTML standard 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2008-08-26 17:19shuehnerNew Issue
2008-08-26 17:19shuehnerAssigned To => cromero
2008-08-26 17:19shuehnersf_bug_id0 => 2076117
2008-08-26 17:19shuehnerOBNetwork customer => No
2008-08-26 17:19shuehnerRegression testing => No
2008-08-26 17:20shuehnerRelationship addedrelated to 0000421
2008-08-26 19:01shuehnerNote Added: 0008763
2008-08-26 19:01shuehnerPrioritynormal => low
2008-08-27 15:39shuehnerDescription Updated
2008-08-27 15:39shuehnerSteps to Reproduce Updated
2008-11-10 13:10cromeroAssigned Tocromero => pjuvara
2008-11-16 18:46pjuvaraStatusnew => acknowledged
2008-11-16 18:46pjuvaraTag Attached: ReleaseCandidate
2009-05-22 19:34pjuvaraAssigned Topjuvara => iciordia
2018-04-08 17:05shuehnerAssigned Toiciordia => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0008763)
shuehner   
2008-08-26 19:01   
This makes no change on the processed HTML-files sent to the browser. These should be identical.

Benefit is cleaner,smaller templates, and much less impact when the codes in this tag needs to change (i.e. renaming of the variable) as the HTML-templates don't need to be modified.