Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0047987Openbravo ERPA. Platformpublic2021-11-04 12:582022-01-10 08:37
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR22Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0047987: Remove obsolete storeserver related code from backoffice
DescriptionLogin flow still has some code to 'Restrict backoffice access for storeservers'.

Storeserver is long obsolete so that code should be removed as cleanup.
Steps To Reproducein backoffice workspace
grep -Iir storeserver
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0047989 closed shuehner Retail Modules Remove obsolete storeserver related code from posterminal 
depends on defect 0048000 closed shuehner Retail Modules Remove obsolete storeserver related code from mobile.core 
depends on defect 0048363 closed alostale Openbravo ERP API change: removed store server code from login flow 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2021-11-04 12:58shuehnerNew Issue
2021-11-04 12:58shuehnerAssigned To => shuehner
2021-11-04 12:58shuehnerOBNetwork customer => No
2021-11-04 12:58shuehnerModules => Core
2021-11-04 12:58shuehnerTriggers an Emergency Pack => No
2021-11-04 13:34shuehnerRelationship addeddepends on 0047989
2021-11-06 11:34shuehnerRelationship addeddepends on 0048000
2021-11-06 11:47hgbotMerge Request Status => open
2021-11-06 11:47hgbotNote Added: 0132880
2022-01-10 07:56alostaleRelationship addeddepends on 0048363
2022-01-10 08:34hgbotMerge Request Statusopen => approved
2022-01-10 08:37hgbotResolutionopen => fixed
2022-01-10 08:37hgbotStatusnew => closed
2022-01-10 08:37hgbotFixed in Version => PR22Q2
2022-01-10 08:37hgbotNote Added: 0134156
2022-01-10 08:37hgbotNote Added: 0134157

Notes
(0132880)
hgbot   
2021-11-06 11:47   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/451 [^]
(0134156)
hgbot   
2022-01-10 08:37   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 34da82586f3de4ae8ec2c2b22d34e5d12825c927
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 10-01-2022 08:12:58
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/34da82586f3de4ae8ec2c2b22d34e5d12825c927 [^]

Fixes ISSUE-47987 Remove obsolete storeserver code

This removes obsolete code leftover from the storeserver project.
Specifically the isLoginAccessRestrictedInStoreServer() code which
allowed to prevent backoffice logins in a storeserver.

As the isThisAStoreServer() condition cannot be true any it is just dead
code

- LoginHandler remove all code conditional on isThisAStoreServer()
  - Also remove vars.removeSessionValue("OnlySystemAdminAccess")
    as that session value name is not referenced anywhere else at all
    so it seems to have no purpose.
- Remove the "RestrictErpAccessInStoreServer" preference completely
  and also it being cached in CachedPreferences
- Finally remove the ServerControllerHandler and ServerController logic
  as it was only useful in context of the storeserver project.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/CachedPreference.java
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/base/secureApp/LoginHandler.java
R src/org/openbravo/server/ServerController.java
R src/org/openbravo/server/ServerControllerHandler.java
---
(0134157)
hgbot   
2022-01-10 08:37   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/451 [^]