Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050527Retail ModulesLoyalty Programs for Web POSpublic2022-10-14 08:542023-07-17 12:17
Reporteralostale 
Assigned Toalainperez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050527: org.openbravo.loyalty.programs cannot be installed with only its declared dependencies
Descriptionorg.openbravo.loyalty.programs module declares a dependency on core only [1] but it is making use of Store Organization Selector that is defined in retail.config module.

---
[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/blob/master/src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml [^]
Steps To ReproduceTry to install org.openbravo.loyalty.programs in an instance without retail
  -> ERROR: it fails

or

Execute DependencyChecker test [1] [2]

ERROR:

* ADColumn(4D75587DB1024799AB0303028F9FD583) (dBColumnName: AD_Org_ID) - module [600C2D0FA00E4274BC5E5ABEE3094BEF] org.openbravo.loyalty.programs
  referenceSearchKey -> ADReference(7E5BA22863C446E89403D51F3F157738) (name: Store Organization Selector) - module [50BF0CEB5D7E438CBBE80688EDB68039] org.openbravo.retail.config

---
[1] https://gitlab.com/openbravo/product/openbravo/-/merge_requests/734 [^]
[2] https://builds.openbravo.com/job/mod-simple/59722/testReport/org.openbravo.test.modularity/DependencyChecker/checkDependencies/ [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0050466 new Triage Platform Base Openbravo ERP implement a dependency checker to prevent incorrect module dependencies 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-10-14 08:54alostaleNew Issue
2022-10-14 08:54alostaleAssigned To => Retail
2022-10-14 08:54alostaleOBNetwork customer => No
2022-10-14 08:54alostaleTriggers an Emergency Pack => No
2022-10-14 08:55alostaleRelationship addedblocks 0050466
2023-04-05 15:00aaroncaleroAssigned ToRetail => alainperez
2023-04-11 17:15hgbotMerge Request Status => open
2023-04-11 17:15hgbotNote Added: 0148381
2023-04-17 17:51alainperezStatusnew => scheduled
2023-07-17 12:15hgbotMerge Request Statusopen => approved
2023-07-17 12:17hgbotNote Added: 0152555
2023-07-17 12:17hgbotResolutionopen => fixed
2023-07-17 12:17hgbotStatusscheduled => closed
2023-07-17 12:17hgbotNote Added: 0152556

Notes
(0148381)
hgbot   
2023-04-11 17:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/8 [^]
(0152555)
hgbot   
2023-07-17 12:17   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/merge_requests/8 [^]
(0152556)
hgbot   
2023-07-17 12:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs [^]
Changeset: e8641dd5b77bb271308e0edac6f91c13a13542d3
Author: Alain Pérez Balart <alain.perez@doceleguas.com>
Date: 17-07-2023 10:17:07
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.loyalty.programs/-/commit/e8641dd5b77bb271308e0edac6f91c13a13542d3 [^]

Fixed ISSUE-50527: Implemented Organization selector to not depend on the Retail Configuration module

---
A src/org/openbravo/loyalty/programs/info/StoreOrganizationSelectorFilterExpression.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
---