Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051274POS2Corepublic2023-01-02 12:522023-03-06 08:34
ReporterjavierRodriguez 
Assigned Togdagnesses 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051274: Improve log when a user action is cancelled
DescriptionWhen a user action is canceled by the user, it is logged the same way as if the user action failed, see:

https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js#L230 [^]

If the captured exception is an instance of ActionCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionCanceled.js [^]) we should show a different message, and if it is an instance of ActionSilentlyCanceled (https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/ActionSilentlyCanceled.js [^]) we should show a different message too.

Both exceptions should be able to receive an optional message in their constructor. If one of those exceptions contains a message, the message should be included in the message written in the log.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005152523Q1 closed gdagnesses Improve log when a user action is cancelled 
related to defect 0056427 closed Triage Platform Base When user action is cancelled Custom messages are not logged in terminal logs 
causes defect 0052814 closed Triage Platform Base error saving "afc" terminal log 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-02 12:52javierRodriguezNew Issue
2023-01-02 12:52javierRodriguezAssigned To => javierRodriguez
2023-01-02 12:52javierRodriguezOBNetwork customer => No
2023-01-02 12:52javierRodriguezTriggers an Emergency Pack => No
2023-01-19 17:22guilleaerAssigned TojavierRodriguez => Triage Platform Base
2023-01-20 09:03AugustoMauchStatusnew => scheduled
2023-01-20 09:03AugustoMauchAssigned ToTriage Platform Base => meriem_azaf
2023-01-20 14:42AugustoMauchSummaryCreate log when a user action is cancelled => Improve log when a user action is cancelled
2023-01-20 14:42AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=25433#r25433
2023-01-24 15:46hgbotMerge Request Status => open
2023-01-24 15:46hgbotNote Added: 0145797
2023-01-24 15:53hgbotNote Added: 0145798
2023-02-01 11:04guilleaerStatusscheduled => acknowledged
2023-02-01 11:04guilleaerStatusacknowledged => scheduled
2023-02-01 16:18hgbotNote Added: 0146133
2023-02-01 16:36hgbotNote Added: 0146136
2023-02-01 19:27hgbotNote Added: 0146141
2023-02-01 19:28hgbotNote Added: 0146142
2023-02-02 12:53guilleaerNote Deleted: 0145798
2023-02-02 12:53guilleaerNote Deleted: 0146133
2023-02-02 12:54guilleaerAssigned Tomeriem_azaf => gdagnesses
2023-02-02 13:21hgbotNote Added: 0146167
2023-02-02 14:29hgbotMerge Request Statusopen => approved
2023-02-02 14:29hgbotNote Added: 0146170
2023-02-02 14:29hgbotNote Added: 0146171
2023-02-02 14:29hgbotNote Added: 0146172
2023-02-02 14:29hgbotNote Added: 0146173
2023-02-02 14:29hgbotNote Added: 0146174
2023-02-02 14:29hgbotNote Added: 0146175
2023-02-02 14:29hgbotResolutionopen => fixed
2023-02-02 14:29hgbotStatusscheduled => closed
2023-02-02 14:29hgbotNote Added: 0146176
2023-02-02 14:29hgbotFixed in Version => 23Q2
2023-02-02 14:29hgbotNote Added: 0146177
2023-03-06 08:34hgbotNote Added: 0147283
2023-06-21 12:59alostaleRelationship addedcauses 0052814
2024-09-10 18:08Rajesh_18Relationship addedrelated to 0056427

Notes
(0145797)
hgbot   
2023-01-24 15:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/463 [^]
(0146136)
hgbot   
2023-02-01 16:36   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/974 [^]
(0146141)
hgbot   
2023-02-01 19:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/67 [^]
(0146142)
hgbot   
2023-02-01 19:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/202 [^]
(0146167)
hgbot   
2023-02-02 13:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1500 [^]
(0146170)
hgbot   
2023-02-02 14:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions [^]
Changeset: 3688ac85852e17f17131fc53aa97741e5eb39024
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 02-02-2023 13:47:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/commit/3688ac85852e17f17131fc53aa97741e5eb39024 [^]

Related to ISSUE-51274: Fixes tests

---
M web-jspack/org.openbravo.retail.sessions/src/model/till/user-actions/__test__/SetBusinessDate.test.js
---
(0146171)
hgbot   
2023-02-02 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sessions/-/merge_requests/67 [^]
(0146172)
hgbot   
2023-02-02 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/202 [^]
(0146173)
hgbot   
2023-02-02 14:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^]
Changeset: b398b083494d6c1dffbed5865bc9f843ddc9bebc
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 02-02-2023 13:46:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/b398b083494d6c1dffbed5865bc9f843ddc9bebc [^]

Related to ISSUE-51274: Fixes tests

---
M web-jspack/org.openbravo.pos2.restaurant/src/model/ticket/user-actions/__test__/FinishProductConfigurationStep.test.js
M web-jspack/org.openbravo.pos2.restaurant/src/model/user-interface/__test__/SelectLineHooks.test.js
---
(0146174)
hgbot   
2023-02-02 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1500 [^]
(0146175)
hgbot   
2023-02-02 14:29   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cb2c10d3468f110b548948c9b8b6c4ffab1d745e
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 02-02-2023 12:39:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cb2c10d3468f110b548948c9b8b6c4ffab1d745e [^]

Related to ISSUE-51274: Fixes tests

---
M web-jspack/org.openbravo.pos2/src/components/Service/__test__/FinalMandatoryServicePaymentFlow.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/AddNewProofOfPaymentSelectedLinesUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentDivideEquallyUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/proofOfPayment/__test__/NewProofOfPaymentFillInAmountUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/FinishProductConfigurationStep.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/OpenTerminalScheduleUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SwitchToCashupWindow.test.js
---
(0146176)
hgbot   
2023-02-02 14:29   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/974 [^]
(0146177)
hgbot   
2023-02-02 14:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 2790803e6a83e03ba0aec4f05009f236d32c8102
Author: Guillermo Dagnesses Segura <guillermo.dagnesses@doceleguas.com>
Date: 02-02-2023 14:28:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/2790803e6a83e03ba0aec4f05009f236d32c8102 [^]

Fixed ISSUE-51274: Improve log when a user action is cancelled

Whether an action is canceled silently or not, the user action will
write terminal log indicating that the action was canceled, with the
proper context

---
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowFlowSwitchAction.test.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/WindowSwitchAction.test.js
M web-jspack/org.openbravo.core2/src/model/terminal-log/actions/addUserAction.js
---
(0147283)
hgbot   
2023-03-06 08:34   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/463 [^]