Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051879Retail ModulesDiscounts and Promotionspublic2023-03-16 08:222023-04-03 19:40
Reporternoemieroussel 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051879: [Promo] - Buy X Get Y - Number of gifts is multiplied by number of eligible products bought even if Max Y = 1
DescriptionRelates to: https://issues.openbravo.com/view.php?id=50976 [^]

When configuring Buy X Get Y, the number of gifts is multiplied by number of eligible products bought even if Max Y = 1. Moreover, when adding several gifts to the ticket, only one is free.
Steps To ReproduceStep 1: Definition of promotion

                Name: Test number of gift multiplied

                Type: Buy X get Y as a gift

               Subtype: Here Buy Any X Get Any Y (But this bug concerns the 4
               subtypes)

               Application Method: Optional

               Add in the list of products in "Product subtab":

               Product: “Alpine poles “

               Product: “Blue Coat “

               Gift Product: “Beer 0.5L”

X = 1
Min Y = 1
Max Y = 1

Step 2: Add one eligible product to the ticket, only one gift can be selected among the 3 possible gifts defined => Result OK

Step 3 : Add a second eligible product to the ticket --> KO
The pop up indicates that 2 eligible products can be selected instead of 1 (number of gifts is equal to the number of eligible products bought)
When we select only one gift and click on Apply, error message is displayed

Step 4: We select 2 gifts and click on Apply --> KO both gifts are added to the ticket, but only one is free
Proposed SolutionExpected behavior : If max Y = 1, only one gift can be offered to the client, even if he buys several eligible products - we expect the same pop up and behavior as when only one eligible product is bought (requirement 3 in the specification)
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051795 closed ranjith_qualiantech_com Retail Modules When "Apply only once" is uncheck, it is possible to add gift endlessly 
related to defect 0052053 closed guilleaer POS2 buy x gift y popup not show if pending gifts 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-16 08:22noemierousselNew Issue
2023-03-16 08:22noemierousselAssigned To => Retail
2023-03-16 08:22noemierousselOBNetwork customer => Gold
2023-03-16 08:22noemierousselTriggers an Emergency Pack => No
2023-03-20 11:11noemierousselNote Added: 0147694
2023-03-27 08:40ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-03-27 08:40ranjith_qualiantech_comStatusnew => scheduled
2023-03-27 08:42guillermogilSticky IssueNo => Yes
2023-03-27 08:42guillermogilSticky IssueYes => No
2023-03-29 08:13noemierousselNote Deleted: 0147694
2023-03-29 17:01gorka_gilNote Added: 0148057
2023-03-30 11:16ranjith_qualiantech_comRelationship addedrelated to 0051795
2023-04-03 19:40gorka_gilNote Added: 0148218
2023-04-03 19:40gorka_gilStatusscheduled => closed
2023-04-03 19:40gorka_gilResolutionopen => no change required
2023-04-03 19:51gorka_gilRelationship addedrelated to 0052053

Notes
(0148057)
gorka_gil   
2023-03-29 17:01   
Needed fix:
- the min should be the min of the promotion,
instead the sum of the mins
- the max should remain the same (sum of maxes)

I only remember about the problem in the popup, but as far as I remember the rule was working fine once it is added to the ticket, please test again and ensure the apply only once it is not check
(0148218)
gorka_gil   
2023-04-03 19:40   
This issue report two things:
- 1) If a promotion can be applied twice, in the popup the min should be the min y, not the twice the min y.
- 2) If applied twice to the ticket manually, only one gift it is taken as gift

Right now, in livebuilds both things are working, so rejecting this issue.