Openbravo Issue Tracking System - Retail Modules
View Issue Details
0051982Retail ModulesSend By Emailpublic2023-03-27 11:382023-04-04 12:45
nicola_uva 
ranjith_qualiantech_com 
immediatemajoralways
closedfixed 
5
 
pi 
approved
Gold
No
0051982: Send Email is triggered before order getting processed
Send Email is triggered before order getting processed.

java.lang.NullPointerException
    at org.openbravo.retail.sendemail.classes.OBSMAIL_MailSender.sendEmail(OBSMAIL_MailSender.java:125)
    at org.openbravo.retail.sendemail.sync.OBSMAIL_SendEmailFromImportEntry.saveRecord(OBSMAIL_SendEmailFromImportEntry.java:45)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:434)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:348)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
2023-03-27 15:00:00,249 [Import Entry - 6] ERROR org.openbravo.service.importprocess.ImportEntryProcessor.ImportEntryProcessRunnable - JSONObject["id"] not found.
org.codehaus.jettison.json.JSONException: JSONObject["id"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) ~[jettison-1.3-patched.jar:?]
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) ~[jettison-1.3-patched.jar:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:255) ~[classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) ~[classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) ~[classes/:?]
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57) ~[classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:434) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:348) [classes/:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]




Backoffice
1) Configure Email Config
2) Enable Send Email (Through preference, Touchpoint type)
POS
1) Add all best sellers products (Mandatory)
2) Complete ticket
3) Send Mail & Continue
Error occurred in backoffice. (Mail not sent). (If error not occurred , retry steps 1 to 3)
email event must be triggered after order is processed.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/blob/master/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java#L125 [^]
No tags attached.
Issue History
2023-03-27 11:38nicola_uvaNew Issue
2023-03-27 11:38nicola_uvaAssigned To => Retail
2023-03-27 11:38nicola_uvaOBNetwork customer => No
2023-03-27 11:38nicola_uvaTriggers an Emergency Pack => No
2023-03-27 12:06ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-03-27 12:06ranjith_qualiantech_comStatusnew => scheduled
2023-03-27 12:15nicola_uvaOBNetwork customerNo => Gold
2023-03-27 12:15nicola_uvaReproducibilityhave not tried => always
2023-03-27 17:41nicola_uvaProposed Solution updated
2023-03-28 06:41ranjith_qualiantech_comSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=25773#r25773
2023-03-28 07:10hgbotMerge Request Status => open
2023-03-28 07:10hgbotNote Added: 0148003
2023-04-04 12:45hgbotMerge Request Statusopen => approved
2023-04-04 12:45hgbotResolutionopen => fixed
2023-04-04 12:45hgbotStatusscheduled => closed
2023-04-04 12:45hgbotNote Added: 0148246
2023-04-04 12:45hgbotNote Added: 0148247

Notes
(0148003)
hgbot   
2023-03-28 07:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/18 [^]
(0148246)
hgbot   
2023-04-04 12:45   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^]
Changeset: dbf3338d6c39502a9ecce276042dfbaf1ecbb676
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-04-2023 18:05:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/dbf3338d6c39502a9ecce276042dfbaf1ecbb676 [^]

Fixed ISSUE-51982: Import entry should not processed if order/invoice is not present
* Send Email Import entry should not processed if order/invoice is not processed

---
M src/org/openbravo/retail/sendemail/OBSMAIL_Utils.java
M src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java
M src/org/openbravo/retail/sendemail/sync/OBSMAIL_ImportEntryProcessor.java
---
(0148247)
hgbot   
2023-04-04 12:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/18 [^]