Openbravo Issue Tracking System - Openbravo Localizations
View Issue Details
0058332Openbravo LocalizationsLocalization Francepublic2025-03-25 10:442025-03-27 08:29
kousalya_r 
kousalya_r 
normalmajorhave not tried
closedfixed 
5
 
 
approved
No
0058332: Wrong taxes and totals when issuing an order with deposits.
When issuing a completely paid order that has had deposit invoices associated, the taxes and totals are wrong in the printed ticket. This also causes an exception in backoffice, generating an EWI.
Configure deposit invoice.

Create a sale with a product (or more) that is pickup in store, a client with invoice terms after delivery, and adding a prepayment that is not the complete amount of the ticket.

Open the created order, and pay it completely.

Issue the order.
The wrong Invoice quantities are generated and the following exception is launched:

org.openbravo.base.exception.OBException: Error in OrderLoader: null
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:567) ~[classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) [classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) [classes/:?]
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:55) [classes/:?]
    at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:64) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:447) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:370) [classes/:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]
Caused by: java.lang.NullPointerException
    at org.openbravo.retail.posterminal.utility.InvoiceUtils.createInvoiceLine(InvoiceUtils.java:244) ~[classes/:?]
    at org.openbravo.retail.posterminal.utility.InvoiceUtils.createInvoiceLines(InvoiceUtils.java:376) ~[classes/:?]
    at org.openbravo.retail.posterminal.utility.InvoiceUtils.createInvoiceAndLines(InvoiceUtils.java:121) ~[classes/:?]
    at org.openbravo.retail.posterminal.utility.InvoiceUtils.createNewInvoice(InvoiceUtils.java:91) ~[classes/:?]
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:527) ~[classes/:?]
No tags attached.
png image-20250307-113325.png (52,961) 2025-03-25 10:44
https://issues-new.openbravo.com/file_download.php?file_id=21081&type=bug
png
Issue History
2025-03-25 10:44kousalya_rNew Issue
2025-03-25 10:44kousalya_rFile Added: image-20250307-113325.png
2025-03-25 10:44kousalya_rOBNetwork customer => No
2025-03-25 10:55hgbotMerge Request Status => open
2025-03-25 10:55hgbotNote Added: 0177213
2025-03-26 06:13jonaeAssigned To => kousalya_r
2025-03-26 11:02hgbotMerge Request Statusopen => approved
2025-03-26 11:02hgbotResolutionopen => fixed
2025-03-26 11:02hgbotStatusnew => closed
2025-03-26 11:02hgbotFixed in Version => 25Q2
2025-03-26 11:02hgbotNote Added: 0177261
2025-03-26 11:02hgbotNote Added: 0177262
2025-03-26 11:10hgbotNote Added: 0177263
2025-03-26 11:28hgbotNote Added: 0177266
2025-03-27 08:29hgbotNote Added: 0177304
2025-03-27 08:29hgbotNote Added: 0177305

Notes
(0177213)
hgbot   
2025-03-25 10:55   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3662 [^]
(0177261)
hgbot   
2025-03-26 11:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 194fd7f79fcc4ceb088fc078cbf6cd32ddbe7d1a
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 26-03-2025 05:13:54
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/194fd7f79fcc4ceb088fc078cbf6cd32ddbe7d1a [^]

Fixed ISSUE-58332: Tax is calculated for negative lines

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
---
(0177262)
hgbot   
2025-03-26 11:02   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3662 [^]
(0177263)
hgbot   
2025-03-26 11:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 78f45bd75a52fe1ff1531a560c4d6589b1951dbd
Author: Igor Trebol <igor.trebol@openbravo.com>
Date: 26-03-2025 11:10:06
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/78f45bd75a52fe1ff1531a560c4d6589b1951dbd [^]

Revert "Fixed ISSUE-58332: Tax is calculated for negative lines"

This reverts commit 194fd7f79fcc4ceb088fc078cbf6cd32ddbe7d1a.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
---
(0177266)
hgbot   
2025-03-26 11:28   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3667 [^]
(0177304)
hgbot   
2025-03-27 08:29   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3667 [^]
(0177305)
hgbot   
2025-03-27 08:29   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 268500ffb075b19b6d78c3940ddaf68e18ad0234
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 27-03-2025 10:31:16
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/268500ffb075b19b6d78c3940ddaf68e18ad0234 [^]

Fixed ISSUE-58332: Tax is calculated for negative lines

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__mock__/MockDepositInvoice.js
---