Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
| ID | ||||||||||||
| 0050356 | ||||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| design defect | [Openbravo ERP] A. Platform | minor | have not tried | 2022-09-27 17:23 | 2022-09-27 17:25 | |||||||
| Reporter | caristu | View Status | public | |||||||||
| Assigned To | Triage Platform Base | |||||||||||
| Priority | high | Resolution | open | Fixed in Version | ||||||||
| Status | new | Fix in branch | Fixed in SCM revision | |||||||||
| Projection | none | ETA | none | Target Version | ||||||||
| OS | Any | Database | Any | Java version | ||||||||
| OS Version | Database version | Ant version | ||||||||||
| Product Version | SCM revision | |||||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | ||||||||||||
| OBNetwork customer | No | |||||||||||
| Web browser | ||||||||||||
| Modules | Core | |||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0050356: Do not used generated JS code for defining sort normalizers | |||||||||||
| Description | Currently we are using some generated code to define the sort normalizer function used by some references. See an example here[1]. Instead of using generating code for defining the function: sortNormalizer: function (item, field, context){ return OB.Utilities.yesNoSortNormalizer(item, field, context);} we should generate agnostic content sortNormalizer: OB.Utilities.yesNoSortNormalizer [1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/YesNoUIDefinition.java#L68 [^] | |||||||||||
| Steps To Reproduce | . | |||||||||||
| Proposed Solution | The main reason behind the current definition is that the normalizer functions are all defined in the ob-utilities file of the org.openbravo.client.application module, which is loaded after the code that defines the Smartclient types (because it is in a different component provider). To avoid this we should move the definition of the normalizer functions from the ob-utilities file to a separate file that is imported with a component provider of a module that loads its content before the Smartclient types definition. One option could be to place them in the org.openbravo.client.kernel.module. Note this module already has a ob-kernel-utilities.js file. The detected references with this problem so far are: - YesNoUIDefinition - ForeignKeyUIDefinition - RelevantCharacteristicProperty | |||||||||||
| Tags | No tags attached. | |||||||||||
| Attached Files | ||||||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-27 17:23 | caristu | New Issue | |
| 2022-09-27 17:23 | caristu | Assigned To | => Triage Platform Base |
| 2022-09-27 17:23 | caristu | OBNetwork customer | => No |
| 2022-09-27 17:23 | caristu | Modules | => Core |
| 2022-09-27 17:23 | caristu | Triggers an Emergency Pack | => No |
| 2022-09-27 17:25 | caristu | Description Updated | View Revisions |
| Copyright © 2000 - 2009 MantisBT Group |