Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031557
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. PlatformtrivialN/A2015-11-23 08:322015-12-21 10:10
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritylowResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4b1da36d4b2c
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toshuehner
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031557: NumberFilter: unneeded @SuppressWarnings("unused") annontation

DescriptionIn org.openbravo.base.filter.NumberFilter.accept there is a @SuppressWarnings("unused") annotation which causes an unnecessary unneeded warning because the method is public and it is actually used.
Steps To ReproduceSee warning in enclipse
Proposed SolutionRemove annotation
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0031477 newshuehner Tracking issue to reduce the huge number of eclipse warnings in pi 
related to defect 00302823.0PR15Q3 closedshuehner Supress some warnings about 'unused object allocation' where this is intentional 

-  Notes
(0082055)
hgbot (developer)
2015-11-23 08:36

 Repository: erp/devel/pi
Changeset: 4b1da36d4b2cc391880073b4442440b1c89e3f75
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Nov 23 08:35:22 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4b1da36d4b2cc391880073b4442440b1c89e3f75 [^]

fixed issue 31557: NumberFilter unneeded @SuppressWarnings("unused")

---
M src-core/src/org/openbravo/base/filter/NumberFilter.java
---
(0082261)
hudsonbot (viewer)
2015-11-23 21:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082882)
shuehner (administrator)
2015-12-21 10:10

 Reviewed.

Non-functional change only.

Change was to revert an earlier change by myself to suppress a optionally shown eclipse warning (Unused object allocation).

However as that warning is optional that earlier change triggered a new warning about that supression being unused when eclipse is used with the openbravo standard warning configuration.

So that revert here makes sense for now to not have a new warning by default.

- Issue History
Date Modified Username Field Change
2015-11-23 08:32 alostale New Issue
2015-11-23 08:32 alostale Assigned To => alostale
2015-11-23 08:32 alostale OBNetwork customer => No
2015-11-23 08:32 alostale Modules => Core
2015-11-23 08:32 alostale Triggers an Emergency Pack => No
2015-11-23 08:33 alostale Relationship added related to 0031477
2015-11-23 08:33 alostale Relationship added related to 0030282
2015-11-23 08:36 hgbot Checkin
2015-11-23 08:36 hgbot Note Added: 0082055
2015-11-23 08:36 hgbot Status new => resolved
2015-11-23 08:36 hgbot Resolution open => fixed
2015-11-23 08:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4b1da36d4b2cc391880073b4442440b1c89e3f75 [^]
2015-11-23 08:36 alostale Review Assigned To => shuehner
2015-11-23 21:17 hudsonbot Checkin
2015-11-23 21:17 hudsonbot Note Added: 0082261
2015-12-21 10:10 shuehner Note Added: 0082882
2015-12-21 10:10 shuehner Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker