Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0043151
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-02-07 13:372020-06-22 11:33
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version3.0PR20Q2
StatusclosedFix in branchFixed in SCM revision2af9d85febef
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0043151: Apply new HQL Style in ResetStockValuation.java

DescriptionResetStockValuation.java has one HQL query with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Tracking issue: Convert HQL to apply new style 

-  Notes
(0117809)
inigo_lerga (viewer)
2020-02-14 13:57

 --Test Plan Mantis HQL queries--
As the F&B International Group Admin role:
    - Go to the Reset Unit Cost window and select any Organization.
      Press the Done Button.

    #In this moment another modified HQLs are executed#
(0118155)
hgbot (developer)
2020-02-27 12:55

 Repository: erp/devel/pi
Changeset: 2af9d85febef5dadbe9f13af22f1889f34c46323
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Thu Feb 13 17:33:34 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2af9d85febef5dadbe9f13af22f1889f34c46323 [^]

fixes BUG-43151:Applied new HQL Style + license msg added

---
M src/org/openbravo/costing/ResetStockValuation.java
---
(0118156)
hgbot (developer)
2020-02-27 12:55

 Repository: erp/devel/pi
Changeset: 039bcab72e6dfa6801150c45ea2e10c4d36fcc6a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri Feb 14 13:42:37 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/039bcab72e6dfa6801150c45ea2e10c4d36fcc6a [^]

related to ISSUE-43151: Applied Sonarlint suggestions and more

Sonarlint suggestions applied.
Finals added.
HQL query updated with current format.
getResponseBuilder used when available to send messages.

---
M src/org/openbravo/costing/ResetStockValuation.java
---
(0118157)
dmiguelez (viewer)
2020-02-27 12:56

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-02-07 13:37 inigo_lerga New Issue
2020-02-07 13:37 inigo_lerga Assigned To => inigo_lerga
2020-02-07 13:37 inigo_lerga OBNetwork customer => No
2020-02-07 13:37 inigo_lerga Modules => Core
2020-02-07 13:37 inigo_lerga Triggers an Emergency Pack => No
2020-02-13 13:47 inigo_lerga Status new => scheduled
2020-02-14 13:57 inigo_lerga Note Added: 0117809
2020-02-27 12:55 hgbot Checkin
2020-02-27 12:55 hgbot Note Added: 0118155
2020-02-27 12:55 hgbot Status scheduled => resolved
2020-02-27 12:55 hgbot Resolution open => fixed
2020-02-27 12:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2af9d85febef5dadbe9f13af22f1889f34c46323 [^]
2020-02-27 12:55 hgbot Checkin
2020-02-27 12:55 hgbot Note Added: 0118156
2020-02-27 12:56 dmiguelez Review Assigned To => dmiguelez
2020-02-27 12:56 dmiguelez Note Added: 0118157
2020-02-27 12:56 dmiguelez Status resolved => closed
2020-02-27 12:56 dmiguelez Fixed in Version => 3.0PR20Q2
2020-06-22 11:33 inigo_lerga Relationship added related to 0041287

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker