Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044799
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Initial data loadminorhave not tried2020-08-12 16:442020-09-07 13:34
ReportershuehnerView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044799: IDL_Check_DataType is an old-style callout and should be refactored to use SimpleCallout

DescriptionThis callout is one of the few ones left over not not refactored to be SimpleCallout (issue 36067 refactored every supported module except a few one).

Steps To Reproduceproduct/pmods/org.openbravo.idl/src/org/openbravo/idl/ad_callouts/IDL_Check_DataType.java: resultado.append("var respuesta = new Array(");
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0044795 newTriage Omni OMS Openbravo ERP Tracking issue to refactor remaining old callouts to extend SimpleCallout 

-  Notes
(0122098)
shuehner (administrator)
2020-08-17 12:54

 When fixing this issue the AD_MODEL_OBJECT_MAPPING entry should be removed (not needed and SimpleCallout subclasses are not servlets)
(0122547)
hgbot (developer)
2020-09-02 14:18

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/merge_requests/2 [^]
(0122548)
inigo_lerga (viewer)
2020-09-02 15:21
edited on: 2020-09-07 13:33

 --Test Plan Mantis--
Beforehand, the Initial Data Load module must be installed.
After deleting the AD_MODEL_OBJECT_MAPPING, this class is executed when a
change is done in the Default Value field described bellow, as the class is registered as a Callout in Application Dictionary

As the F&B International Group Admin role in Backend:

1. Apply module dataset:
  - Go to Enterprise Module Management window and select the
    Initial Data Load Module. Press OK button.

2. Test Default values:
  - Go to Entity Default Values window and open the Product record.
  - Go to Fields Tab and create a new record with:
    - Name: Test
    - Data Type: Boolean
    - Default Value: a
    - In this moment the new SimpleCallout is executed, showing an Info message when the Default Value inserted does not match the structure of the Boolean Type selected (Example: Data Type 'Boolean' and Default Value 'a'"
  - Create a new record with:
    - Name: Test
    - Data Type: Numeric
    - Default Value: a
    - In this moment the new SimpleCallout is executed, showing an Info message when the Default Value inserted does not match the structure of the Numeric Type selected (Example: Data Type 'Numeric' and Default Value 'a'"
  - Create a new record with:
    - Name: Test
    - Data Type: Date
    - Default Value: a
    - In this moment the new SimpleCallout is executed, showing an Info message when the Default Value inserted does not match the structure of the Date Type selected (Example: Data Type 'Date' and Default Value 'a'"
(0122749)
hgbot (developer)
2020-09-07 13:34

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/merge_requests/2 [^]
(0122750)
hgbot (developer)
2020-09-07 13:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl [^]
Changeset: 94759d83ca8a1c452619d62e76719c164c0ecd57
Author: inigo_lerga <inigo.lerga@openbravo.com>
Date: 2020-09-02T14:05:27+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/commit/94759d83ca8a1c452619d62e76719c164c0ecd57 [^]

fixes BUG-44799:IDL_Check_DataType to SimpleCallout

Transformed from old-style callout to SimpleCallout.
Also AD_MODEL_OBJECT_MAPPING entry removed.

---
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
M src/org/openbravo/idl/ad_callouts/IDL_Check_DataType.java
---

- Issue History
Date Modified Username Field Change
2020-08-12 16:44 shuehner New Issue
2020-08-12 16:44 shuehner Assigned To => Jorge Bravo
2020-08-12 16:44 shuehner OBNetwork customer => No
2020-08-12 16:44 shuehner Issue generated from 0044798
2020-08-12 16:45 shuehner Relationship added blocks 0044795
2020-08-12 16:46 shuehner Issue cloned 0044800
2020-08-12 16:55 shuehner Assigned To Jorge Bravo => Triage Finance
2020-08-17 12:54 shuehner Note Added: 0122098
2020-08-18 08:25 vmromanos Assigned To Triage Finance => inigo_lerga
2020-08-27 14:26 inigo_lerga Status new => scheduled
2020-09-02 14:18 hgbot Merge Request Status => open
2020-09-02 14:18 hgbot Note Added: 0122547
2020-09-02 15:21 inigo_lerga Note Added: 0122548
2020-09-07 09:17 inigo_lerga Note Edited: 0122548 View Revisions
2020-09-07 09:20 inigo_lerga Note Edited: 0122548 View Revisions
2020-09-07 09:21 inigo_lerga Note Edited: 0122548 View Revisions
2020-09-07 09:28 inigo_lerga Note Edited: 0122548 View Revisions
2020-09-07 13:33 dmiguelez Note Edited: 0122548 View Revisions
2020-09-07 13:33 dmiguelez Note Edited: 0122548 View Revisions
2020-09-07 13:34 hgbot Merge Request Status open => approved
2020-09-07 13:34 hgbot Note Added: 0122749
2020-09-07 13:34 hgbot Resolution open => fixed
2020-09-07 13:34 hgbot Status scheduled => closed
2020-09-07 13:34 hgbot Note Added: 0122750

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker