0051846: Problem when changing price list w/ taxes to pricelist w/o taxes in web pos

Description

In version 18, in web pos, when the user selected a business partner with a pricelist without taxes, the price list used in the receipt was changed to that pricelist regardless of the one that had the terminal configured.

Now they have version 23q1 and with the fix of issue https://issues.openbravo.com/view.php?id=41927, [^] the behavior has changed: if the selected business partner's price list is different of the terminal's pricelist configuration, an error popup is shown, and the terminal's pricelist is used in the receipt.

They want the previous behavior and have disabled the validation with the provided patch.

Steps To Reproduce

1- In back office, have a business partner with pricelist without taxes
2- In web pos, have a terminal with pricelist configured with taxes
3- In web pos, select the business partner of step 1.
4- The popup is shown and the terminal's pricelist is used.

Video provided by the partner: https://youtu.be/S8QkeIl6ZgA [^]

Proposed Solution

Patch attached

Tags

No tags attached.

Attached Files

changepricelistissue.diff [^] (2,727 bytes) 2023-03-13 23:35 [Show Content] [Hide Content]

diff -ru Original/businesspartner_selector.js Modificado/businesspartner_selector.js
--- a/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js	2023-03-01 08:13:28.000000000 +0100
+++ b/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/components/businesspartner_selector.js	2023-03-13 16:50:10.580070690 +0100
@@ -130,9 +130,7 @@
           model.get('isEditable') &&
           !model.get('cloningReceipt') &&
           OB.MobileApp.model.hasPermission('EnableMultiPriceList', true) &&
-          (model.get('priceIncludesTax') !==
-            OB.MobileApp.model.get('pricelist').priceIncludesTax ||
-            model.get('bp').get('priceListCurrency') !==
+          (model.get('bp').get('priceListCurrency') !==
               OB.MobileApp.model.get('pricelist').currency)
         ) {
           model.set('priceList', OB.MobileApp.model.get('pricelist').id, {
@@ -1568,3 +1566,4 @@
     this.setFilters(filterProperties);
   }
 });
+
diff -ru Original/order.js Modificado/order.js
--- a/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/model/order.js	2023-03-01 08:13:28.000000000 +0100
+++ b/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/model/order.js	2023-03-13 16:50:15.620070700 +0100
@@ -4770,8 +4770,6 @@
             .priceIncludesTax;
         }
         if (
-          priceIncludesTax !==
-            OB.MobileApp.model.get('pricelist').priceIncludesTax ||
           bp.get('priceListCurrency') !==
             OB.MobileApp.model.get('pricelist').currency
         ) {
@@ -9489,3 +9487,4 @@
 
   window.OB.Model.modelLoaders = [];
 })();
+
diff -ru Original/ReturnVerifiedTicket.js Modificado/ReturnVerifiedTicket.js
--- a/modules/org.openbravo.retail.returns/web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js	2023-03-01 08:13:26.000000000 +0100
+++ b/modules/org.openbravo.retail.returns/web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js	2023-03-13 16:51:14.724070817 +0100
@@ -304,9 +304,7 @@
       OB.App.State.Ticket.Utils.isEditable(ticket) &&
       ticket.businessPartner.priceList !==
         payload.ticket.businessPartner.priceList &&
-      (payload.ticket.businessPartner.priceIncludesTax !==
-        payload.pricelist.priceIncludesTax ||
-        payload.ticket.businessPartner.priceListCurrency !==
+      (payload.ticket.businessPartner.priceListCurrency !==
           payload.pricelist.currency)
     ) {
       await OB.App.View.DialogUIHandler.askConfirmation({
@@ -488,3 +486,4 @@
     return newPayload;
   }
 })();
+

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0148150) guillermogil (viewer) 2023-03-31 08:59	The limitation raised on the issue was done on purpose due to Data inconsistency when using Verified Return and Quotations and different taxes configuration on the pricelist of the store vs the BP one

Issue History
Date Modified	Username	Field	Change
2023-03-13 23:35	ffourcade	New Issue
2023-03-13 23:35	ffourcade	Assigned To	=> Retail
2023-03-13 23:35	ffourcade	File Added: changepricelistissue.diff
2023-03-13 23:35	ffourcade	OBNetwork customer	=> OBPS
2023-03-13 23:35	ffourcade	Support ticket	=> 60414
2023-03-13 23:35	ffourcade	Triggers an Emergency Pack	=> No
2023-03-14 09:11	Practics	Issue Monitored: Practics
2023-03-30 11:47	radhakrishnan	Assigned To	Retail => radhakrishnan
2023-03-30 11:47	radhakrishnan	Status	new => scheduled
2023-03-31 08:59	guillermogil	Review Assigned To	=> guillermogil
2023-03-31 08:59	guillermogil	Note Added: 0148150
2023-03-31 08:59	guillermogil	Status	scheduled => closed
2023-03-31 08:59	guillermogil	Resolution	open => no change required