0051982: Send Email is triggered before order getting processed

Description

Send Email is triggered before order getting processed.

java.lang.NullPointerException
    at org.openbravo.retail.sendemail.classes.OBSMAIL_MailSender.sendEmail(OBSMAIL_MailSender.java:125)
    at org.openbravo.retail.sendemail.sync.OBSMAIL_SendEmailFromImportEntry.saveRecord(OBSMAIL_SendEmailFromImportEntry.java:45)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:434)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:348)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
2023-03-27 15:00:00,249 [Import Entry - 6] ERROR org.openbravo.service.importprocess.ImportEntryProcessor.ImportEntryProcessRunnable - JSONObject["id"] not found.
org.codehaus.jettison.json.JSONException: JSONObject["id"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) ~[jettison-1.3-patched.jar:?]
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) ~[jettison-1.3-patched.jar:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:255) ~[classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165) ~[classes/:?]
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97) ~[classes/:?]
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57) ~[classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:434) [classes/:?]
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:348) [classes/:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) [?:?]
    at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) [?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) [?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]

Steps To Reproduce

Backoffice
1) Configure Email Config
2) Enable Send Email (Through preference, Touchpoint type)
POS
1) Add all best sellers products (Mandatory)
2) Complete ticket
3) Send Mail & Continue
Error occurred in backoffice. (Mail not sent). (If error not occurred , retry steps 1 to 3)

Proposed Solution

email event must be triggered after order is processed.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/blob/master/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java#L125 [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0148003) hgbot (developer) 2023-03-28 07:10	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/18 [^]

(0148246) hgbot (developer) 2023-04-04 12:45	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^] Changeset: dbf3338d6c39502a9ecce276042dfbaf1ecbb676 Author: Ranjith S R <ranjith@qualiantech.com> Date: 03-04-2023 18:05:18 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/dbf3338d6c39502a9ecce276042dfbaf1ecbb676 [^] Fixed ISSUE-51982: Import entry should not processed if order/invoice is not present * Send Email Import entry should not processed if order/invoice is not processed --- M src/org/openbravo/retail/sendemail/OBSMAIL_Utils.java M src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java M src/org/openbravo/retail/sendemail/sync/OBSMAIL_ImportEntryProcessor.java ---

(0148247) hgbot (developer) 2023-04-04 12:45	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/18 [^]

Issue History
Date Modified	Username	Field	Change
2023-03-27 11:38	nicola_uva	New Issue
2023-03-27 11:38	nicola_uva	Assigned To	=> Retail
2023-03-27 11:38	nicola_uva	OBNetwork customer	=> No
2023-03-27 11:38	nicola_uva	Triggers an Emergency Pack	=> No
2023-03-27 12:06	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2023-03-27 12:06	ranjith_qualiantech_com	Status	new => scheduled
2023-03-27 12:15	nicola_uva	OBNetwork customer	No => Gold
2023-03-27 12:15	nicola_uva	Reproducibility	have not tried => always
2023-03-27 17:41	nicola_uva	Proposed Solution updated
2023-03-28 06:41	ranjith_qualiantech_com	Steps to Reproduce Updated	View Revisions
2023-03-28 07:10	hgbot	Merge Request Status	=> open
2023-03-28 07:10	hgbot	Note Added: 0148003
2023-04-04 12:45	hgbot	Merge Request Status	open => approved
2023-04-04 12:45	hgbot	Resolution	open => fixed
2023-04-04 12:45	hgbot	Status	scheduled => closed
2023-04-04 12:45	hgbot	Note Added: 0148246
2023-04-04 12:45	hgbot	Note Added: 0148247